-
Notifications
You must be signed in to change notification settings - Fork 7.9k
Increase maximum size of an uploaded file to 50Mbyte #9315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
This won't really change anything, though. You'd need to change the actual default values. Anyhow, I think this should first be discussed on the internals mailing list. |
Can you send this to the PHP internals list? |
Yes, I will figure out how to do it and send. |
And remember that the |
For reference: https://externals.io/message/118570 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As noted by @cmb69, please change defaults in
Lines 724 to 725 in f3d8f09
STD_PHP_INI_ENTRY("upload_max_filesize", "2M", PHP_INI_SYSTEM|PHP_INI_PERDIR, OnUpdateLong, upload_max_filesize, php_core_globals, core_globals) | |
STD_PHP_INI_ENTRY("post_max_size", "8M", PHP_INI_SYSTEM|PHP_INI_PERDIR, OnUpdateLong, post_max_size, sapi_globals_struct,sapi_globals) |
@mishanon It seems to me that the discussion here or on internals hasn't reached any conclusion so I think we would need an RFC for such change. Are you prepared to do that? If not, we might need to close this. |
See https://wiki.php.net/rfc/howto about the RFC process. |
Current value is 2Mb. Its so small value, when photo image can take 8Mb on iPhone X.
We should increase it to 50Mb, because DevOps engineers do useless work trying to change it.